Conversation
teknaS47
requested review from
a team,
Eswaraiahsapram,
christoph-jerolimov and
its-mitesh-kumar
as code owners
September 4, 2026 11:59
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
|
🤖 Finished Review · ✅ Success · Started 12:01 PM UTC · Completed 12:15 PM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Cost: $5.09 |
❌ 27 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
ReviewFindingsLow
Labels: PR adds integration tests for scorecard backend modules. |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
fullsend-ai-review
Bot
added
ready-for-merge
Contributor
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
… into scorecard-modules-backend
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
RHIDP-15181
Adds
startTestBackendintegration tests for all 9 scorecard backend modules. Each test verifiesthat the module registers its metric providers (and collectors, where applicable) with the scorecard
plugin at runtime without errors.
Follow-up to the scorecard backend POC in #3414
What's included
module.test.tsfiles - one per module, each usingstartTestBackendwithscorecardPlugin+ the module under testpackage.jsonfiles - addssupertest,@types/supertest,@backstage/plugin-catalog-node, andscorecard-backendas devDependenciesyarn.lockupdated for the new dependenciesModules covered
scorecardCollectorsServiceRefjiraconfig✔️ Checklist